Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: overlay: fix missing DBG_DECAP for Inter-Cluster-SNAT #28466

Merged

Conversation

julianwiedmann
Copy link
Member

For Inter-Cluster-SNAT traffic we tail-call in handle_ipv4() before even reaching the DBG_DECAP message.

Pull up the cilium_dbg() call a bit so that it also applies to inter-cluster-SNAT traffic. While at it also clarify which parameters are relevant for the path that handles decrypted packets.

@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.3 Oct 9, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review October 9, 2023 10:44
@julianwiedmann julianwiedmann requested a review from a team as a code owner October 9, 2023 10:44
For Inter-Cluster-SNAT traffic we tail-call in handle_ipv4() before
even reaching the DBG_DECAP message.

Pull up the cilium_dbg() call a bit so that it also applies to
inter-cluster-SNAT traffic. While at it also clarify which parameters are
relevant for the path that handles decrypted packets.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 10, 2023
@julianwiedmann julianwiedmann merged commit 9dcc5d1 into cilium:main Oct 10, 2023
60 of 61 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-overlay-sec-identity branch October 10, 2023 08:57
@joamaki joamaki mentioned this pull request Oct 10, 2023
4 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.3 Oct 10, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.3 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants