v1.14: avoid relying on golang.org/exp/slices.SortFunc #28473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of `slices.SortFunc` has changed recently, breaking builds for projects that vendor Cilium 1.14 and a newer version of `golang.org/x/exp` with the signature change. Due to the way dependencies work, it's unfortunately not always possible to downgrade `golang.org/x/exp` to a previous version. The patch is based on the patch that has been applied to the main branch to allow upgrading `golang.org/x/exp` but without actually bumping the dependency. ref: 036f1dc Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
the
kind/backports
maintainer-s-little-helper
bot
added
the
backport/1.14
aanm
approved these changes
Oct 9, 2023
christarazi
approved these changes
Oct 9, 2023
|
/test-backport-1.14 |
squeed
approved these changes
Oct 10, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
slices.SortFunchas changed recently, breaking builds for projects that vendor Cilium 1.14 and a newer version ofgolang.org/x/expwith the signature change.Due to the way dependencies work, it's unfortunately not always possible to downgrade
golang.org/x/expto a previous version.The patch is based on the patch that has been applied to the main branch to allow upgrading
golang.org/x/expbut without actually bumping the dependency.ref: 036f1dc