helm: don't expose kvstoremesh metrics if not enabled #28481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the kvstoremesh metrics entry inside the dedicated Service and ServiceMonitor is always inserted if the corresponding setting is enabled (true by default), regardless of whether kvstoremesh is actually enabled or not. Yet, this would create problems when Prometheus attempts to scrape it, as the target port would be closed. Hence, let's update the helm chart so that these entries are inserted only if kvstoremesh is enabled. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug
|
/test |
joamaki
approved these changes
Oct 10, 2023
gandro
approved these changes
Oct 10, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/1.14
tklauser
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the kvstoremesh metrics entry inside the dedicated Service and ServiceMonitor is always inserted if the corresponding setting is enabled (true by default), regardless of whether kvstoremesh is actually enabled or not. Yet, this would create problems when Prometheus attempts to scrape it, as the target port would be closed. Hence, let's update the helm chart so that these entries are inserted only if kvstoremesh is enabled.
Fixes: #issue-number