egressgw: Switch from net to netip #28503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
joestringer
force-pushed
the
pr/joe/netip-once-again-with-feeling
branch
2 times, most recently
from
7d5b0fc
to
18a2405
Compare
|
/test |
joestringer
force-pushed
the
pr/joe/netip-once-again-with-feeling
branch
from
18a2405
to
516f401
Compare
|
/ci-e2e |
joestringer
force-pushed
the
pr/joe/netip-once-again-with-feeling
branch
from
516f401
to
9ecf3ab
Compare
Modernize this section of the codebase by switching over to newer
addressing types provided by recent Go standard libraries.
The most interesting aspect here is the use of netip.Addr{} as the
"invalid ip" value, which is distinct from netip.IPv4Unspecified, ie
"0.0.0.0". Both of these values are used at different times in egress
gateway code, and we must be careful not to conflate them.
addr.IsValid() will determine whether the IP is an actual IP, or if
false, the "invalid ip" uninitialized address.
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/netip-once-again-with-feeling
branch
from
9ecf3ab
to
e3d4d43
Compare
|
/ci-e2e |
|
/test |
markpash
approved these changes
Oct 16, 2023
squeed
approved these changes
Oct 18, 2023
jschwinger233
approved these changes
Oct 20, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize this section of the codebase by switching over to newer
addressing types provided by recent Go standard libraries.
Related: #24246