make: add "run-builder" target #28587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
release-note/misc
Add make target for running bash in the cilium builder container. This provides quick access for the correct build environment, with the correct go version for example. If backported to releases, this makes it easy to to work with go vendoring with different releases, which each require a different Go version to be able to run 'go mod' commands. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
make-run-builder-target
branch
from
d14bdd0
to
405e587
Compare
jibi
approved these changes
Oct 18, 2023
jrajahalme
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add make target for running bash in the cilium builder container. This provides quick access for the correct build environment, with the correct go version for example. If backported to releases, this makes it easy to to work with go vendoring with different releases, which each require a different Go version to be able to run 'go mod' commands.