resource: Fix flaky TestResource_RepeatedDelete #28588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
The fake K8s client checks if the events channel becomes full and panics if it does. Fix this by using a hand-rolled ListerWatcher to have full control over the events channel. Fixes: cilium#28575 Fixes: a7f1eef ("resource: Fix double upserts on subscribe and retrying of delete events") Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/fix-resource-test-watch-channel-flake
branch
from
ec64e2c
to
2435fa6
Compare
tommyp1ckles
approved these changes
Oct 16, 2023
|
/test |
squeed
approved these changes
Oct 18, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
the
needs-backport/1.14
8 tasks
YutaroHayakawa
added
backport-pending/1.14
6 tasks
YutaroHayakawa
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake K8s client checks if the events channel becomes full and panics if it does. Fix this by using a hand-rolled ListerWatcher to have full control over the events channel.
Fixes: #28575
Fixes: a7f1eef ("resource: Fix double upserts on subscribe and retrying of delete events")