Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend cilium scale-test to export results and gather additional data #28594

Merged
merged 4 commits into from Oct 17, 2023
Merged

Extend cilium scale-test to export results and gather additional data #28594

merged 4 commits into from Oct 17, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Oct 13, 2023 •
edited

More details in commit messages.

@marseel
Export scale-test results to GS bucket.
8a34e84 
Changed test to simple node-throughput test to get some performance results.
Format of results corresponds to expected format for perfdash.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel
Fix cleanup cluster in scale-test
9b88e8a 
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel
Export sysdump in scale-test
5c27000 
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@maintainer-s-little-helper
Copy link

Commit fcc6eb3 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 13, 2023
learnitall
learnitall requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two suggestions, but otherwise LGTM! Super exciting!

.github/workflows/scale-test-gce.yaml Outdated Show resolved Hide resolved
.github/workflows/scale-test-gce.yaml Show resolved Hide resolved
@maintainer-s-little-helper
Copy link

Commit fcc6eb3 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@marseel marseel force-pushed the marseel-100-node-scale-test-cl2 branch from 751bae5 to b73eab8 Compare October 16, 2023 10:05
@maintainer-s-little-helper
Copy link

Commit fcc6eb3 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@marseel
Add sha, url and cl2-output to exported data
772283e 
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the marseel-100-node-scale-test-cl2 branch from b73eab8 to 772283e Compare October 16, 2023 10:33
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 16, 2023
@marseel
Copy link
Contributor Author

marseel commented Oct 16, 2023

Successful run: https://github.com/cilium/cilium/actions/runs/6532058299/job/17734518103
Results available in gs://cilium-scale-results/logs/scale-test-marseel-100-node-scale-test-cl2/1697451716/

@marseel marseel added the release-note/misc This PR makes changes that have no direct user impact. label Oct 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 16, 2023
@marseel marseel added area/CI Continuous Integration testing issue or flake dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 16, 2023
@marseel marseel changed the title Marseel 100 node scale test cl2 Extend cilium scale-test to export results and gather additional data Oct 16, 2023
@marseel marseel marked this pull request as ready for review October 16, 2023 10:36
@marseel marseel requested review from a team as code owners October 16, 2023 10:36
@learnitall learnitall added the kind/performance There is a performance impact of this. label Oct 16, 2023
@marseel
Copy link
Contributor Author

marseel commented Oct 17, 2023

Marking as ready to merge as all reviews are done and it modifies new workflow only, so no need to run full tests.

@marseel marseel added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 17, 2023
@joestringer joestringer merged commit 688f2bf into main Oct 17, 2023
42 of 44 checks passed
@joestringer joestringer deleted the marseel-100-node-scale-test-cl2 branch October 17, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbusseneau nbusseneau nbusseneau approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/performance There is a performance impact of this. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marseel @nbusseneau @learnitall @joestringer