helm: Correct spire labels indentation

[sayboras]

Fixes: #28599

fix: Correct spire labels identation in helm chart

[maintainer-s-little-helper]

Commit 5b80406 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 5b80406 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[sayboras]

/test

[sayboras]

/test

[meyskens]

Good catch! LGTM

[joestringer]

@sayboras Could you add a release note to the PR description? Glancing over the changes it looks like it's fixing the labels for SPIRE deployments, so it may be helpful to better highlight that in the release note.

[sayboras]

Could you add a release note to the PR description? Glancing over the changes it looks like it's fixing the labels for SPIRE deployments, so it may be helpful to better highlight that in the release note.

Thanks and done 👍

[joestringer]

@sayboras ah, what I meant is that for a user "fixing the indentation" doesn't declare what the side effects are. If this is a cosmetic change then there's no need to backport and it's not a bugfix. If this ensures that when the user configures the feature with setting X or Y, it actually works, then we should document the user impact that way so that users can understand exactly which configurations are affected and decide if the bug is related to their problem or not. And in that case yeah it makes sense to backport this to 1.14.