Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cilium-operator delete CEC cilium-ingress when other ingressclass resources are created #28638

Merged
merged 1 commit into from Oct 20, 2023
Merged

fixed cilium-operator delete CEC cilium-ingress when other ingressclass resources are created #28638

merged 1 commit into from Oct 20, 2023

Conversation

chaunceyjiang
Copy link
Member

Fixes: #28289

When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

fixed cilium-operator delete CEC cilium-ingress when other ingressclass resources are created

@chaunceyjiang chaunceyjiang requested a review from a team as a code owner October 17, 2023 08:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 17, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 17, 2023
chaunceyjiang added a commit to chaunceyjiang/cilium that referenced this pull request Oct 17, 2023
@chaunceyjiang
fixed cilium-operator delete CEC cilium-ingress when other ingresscla…
6b3ce74 
…ss resources are created

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes cilium#28638
@mhofstetter mhofstetter added release-note/bug This PR fixes an issue in a previous release of Cilium. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-ingress labels Oct 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 17, 2023
@mhofstetter mhofstetter added the kind/bug This is a bug in the Cilium logic. label Oct 17, 2023
@mhofstetter
Copy link
Member

Thanks a lot for the contribution @chaunceyjiang

The check BPF Checks / Check Patch is failing with the following error message.

Please avoid long commit subjects (max: 75, found: 93)

Would be nice if you could shorten the commit message subject (first line) of your commit

chaunceyjiang added a commit to chaunceyjiang/cilium that referenced this pull request Oct 17, 2023
@chaunceyjiang
fixed cilium-operator delete CEC cilium-ingress.
e688156 
When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes cilium#28638
@chaunceyjiang
Copy link
Member Author

@mhofstetter Thank you for your reminder.

@learnitall learnitall added affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 18, 2023
@learnitall learnitall mentioned this pull request Oct 18, 2023
Closed
8 tasks
chaunceyjiang added a commit to chaunceyjiang/cilium that referenced this pull request Oct 19, 2023
@chaunceyjiang
fixed cilium-operator delete CEC cilium-ingress.
919a2c6 
When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes cilium#28638
@chaunceyjiang
fixed cilium-operator delete CEC cilium-ingress.
b99d8ab 
When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes cilium#28638
@mhofstetter
Copy link
Member

/test

mhofstetter
mhofstetter approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for considering my suggestion

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Oct 20, 2023
@joestringer joestringer merged commit d922109 into cilium:main Oct 20, 2023
61 of 62 checks passed
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 24, 2023
@tklauser tklauser mentioned this pull request Oct 24, 2023
Merged
14 tasks
tklauser pushed a commit to tklauser/cilium that referenced this pull request Oct 24, 2023
@chaunceyjiang @tklauser
fixed cilium-operator delete CEC cilium-ingress.
2737aaa 
[ upstream commit d922109 ]

When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes cilium#28638

Signed-off-by: Tobias Klauser <tobias@cilium.io>
dylandreimerink pushed a commit that referenced this pull request Oct 25, 2023
@chaunceyjiang @dylandreimerink
fixed cilium-operator delete CEC cilium-ingress.
dda053d 
[ upstream commit d922109 ]

When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes #28638

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.14 in 1.14.4 Oct 25, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
sayboras pushed a commit that referenced this pull request Nov 25, 2023
@chaunceyjiang @tklauser
fixed cilium-operator delete CEC cilium-ingress.
2515ea6 
[ upstream commit d922109 ]

When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes #28638

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tobias Klauser <tobias@isovalent.com>
@chaunceyjiang chaunceyjiang deleted the shared_cec branch January 2, 2024 09:00
pchaigno pushed a commit that referenced this pull request Jan 8, 2024
@chaunceyjiang @tklauser
fixed cilium-operator delete CEC cilium-ingress.
6c62ba6 
[ upstream commit d922109 ]

When the ingress controller is in shared mode, we create an ingress resources with an ingressclass does not belong to cilium, the ciliumEnvoyConfig resource in kube-system called cilium-ingress is deleted making all ingress routing by cilium fail.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Fixes #28638
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras left review comments

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/k8s-ingress kind/bug This is a bug in the Cilium logic. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.14.4
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium-operator delete CEC cilium-ingress when other ingressclass resources are created
6 participants
@chaunceyjiang @mhofstetter @sayboras @tklauser @joestringer @learnitall