labels: Use slices.Sort instead of sort.Strings #28649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by package "sort" documentation (https://pkg.go.dev/sort#Strings), slices.Sort should be preferred to sort.Strings since it runs faster. Comparison between sort.Strings ("old") and slices.Sort ("new"): name old time/op new time/op delta pkg:github.com/cilium/cilium/pkg/labels goos:linux goarch:amd64 Labels_SortedList-8 787ns ± 4% 736ns ±12% -6.42% (p=0.014 n=7+8) pkg:github.com/cilium/cilium/pkg/labels/cidr goos:linux goarch:amd64 Labels_SortedListCIDRIDs-8 5.22µs ± 8% 4.67µs ± 4% -10.63% (p=0.000 n=10+10) name old alloc/op new alloc/op delta pkg:github.com/cilium/cilium/pkg/labels goos:linux goarch:amd64 Labels_SortedList-8 360B ± 0% 336B ± 0% -6.67% (p=0.000 n=10+10) pkg:github.com/cilium/cilium/pkg/labels/cidr goos:linux goarch:amd64 Labels_SortedListCIDRIDs-8 1.62kB ± 0% 1.60kB ± 0% -1.48% (p=0.000 n=10+10) name old allocs/op new allocs/op delta pkg:github.com/cilium/cilium/pkg/labels goos:linux goarch:amd64 Labels_SortedList-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=10+10) pkg:github.com/cilium/cilium/pkg/labels/cidr goos:linux goarch:amd64 Labels_SortedListCIDRIDs-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=10+10) Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
added
area/daemon
nathanjsweet
approved these changes
Oct 17, 2023
|
/test |
schlosna
reviewed
Oct 17, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
pippolo84
added
needs-backport/1.12
affects/v1.12
pippolo84
added
backport-pending/1.13
pippolo84
added
backport-pending/1.12
backport-done/1.12
pippolo84
removed
the
backport-pending/1.13
pippolo84
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by package "sort" documentation (https://pkg.go.dev/sort#Strings),
slices.Sortshould be preferred tosort.Stringssince it runs faster.Comparison between
sort.Strings("old") andslices.Sort("new"):