v1.14 Backports 2023-10-18 #28670
Merged
v1.14 Backports 2023-10-18 #28670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 08903e0 ] Endpoint.GetLabelsLocked existed on the premise that selector cache could not be locked while endpoint has been locked, due to selector cache locking ip cache in some code paths. This does not seem to be correct, as ip cache calls in to selector cache, not the other way around. With this the Endpoint.GetLabelsLocked can be removed, and SelectorCache.GetLabelsLocked can be used instead also when calling from the Endpoint locked state. This is also in line with the commend on policy DistillPolicy that states that "PolicyOwner (aka Endpoint) is also locked during this call", and then within takes the Selector Cache read lock. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
[ upstream commit cb246d7 ] Have selector cache precompute the most specific CIDR for an identity when the identity is added, rathter than computing it when needed for each MapStateEntry. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
kind/backports
|
/test-backport-1.14 |
qmonnet
approved these changes
Oct 18, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: