Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Remove AWS-CONNMARK-CHAIN iptable rules #28676

Merged
merged 1 commit into from Oct 18, 2023

Conversation

nebril
Copy link
Member

@nebril nebril commented Oct 18, 2023

We were missing some AWS-specific iptable rules that need to be deleted when running in ENI mode.

related: #25804

Remove AWS-CONNMARK-CHAIN iptable rules when running in ENI mode.

We were missing some AWS-specific iptable rules that need to be deleted
when running in ENI mode.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Oct 18, 2023
@nebril nebril requested review from a team as code owners October 18, 2023 12:13
@nebril nebril requested review from joamaki and squeed October 18, 2023 12:13
@nebril
Copy link
Member Author

nebril commented Oct 18, 2023

/test

@joestringer joestringer removed the request for review from joamaki October 18, 2023 18:31
@joestringer joestringer merged commit 8c86d07 into cilium:main Oct 18, 2023
62 of 63 checks passed
@joestringer
Copy link
Member

Do we need to backport this, at least to v1.14?

@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Oct 18, 2023
@nebril nebril added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Oct 19, 2023
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 24, 2023
@tklauser tklauser mentioned this pull request Oct 24, 2023
14 tasks
@tklauser tklauser added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants