Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datapath: alignchecker: allow to extend toCheck and toCheckSizes #28711

Merged
merged 1 commit into from Oct 24, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Oct 20, 2023

make toCheck and toCheckSizes global variables and add a couple of setters (registerToCheck and registerToCheckSizes) so that other implementations can extend these maps for example from init()

@jibi jibi added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Oct 20, 2023
@jibi jibi requested a review from ldelossa October 20, 2023 13:52
@jibi jibi requested a review from a team as a code owner October 20, 2023 13:52
@jibi jibi marked this pull request as draft October 20, 2023 13:54
@jibi jibi force-pushed the pr/jibi/alignchecker-hook branch 2 times, most recently from de80096 to 782096c Compare October 20, 2023 14:07
make toCheck and toCheckSizes global variables and add a couple of setters
(registerToCheck and registerToCheckSizes) so that other implementations can
extend these maps for example from init()

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi
Copy link
Member Author

jibi commented Oct 20, 2023

/test

@jibi jibi marked this pull request as ready for review October 20, 2023 14:38
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 24, 2023
@jibi jibi merged commit d2a4c6f into main Oct 24, 2023
211 of 214 checks passed
@jibi jibi deleted the pr/jibi/alignchecker-hook branch October 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants