Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report endpoint ID on endpoint BPF program #28747

Merged
merged 1 commit into from Oct 25, 2023
Merged

report endpoint ID on endpoint BPF program #28747

merged 1 commit into from Oct 25, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Oct 23, 2023

Presenting only the endpoint interface name into the logs might not be enough to understand which endpoint has the problem. Thus, we should print the endpoint ID well.

Fixes: d93659c ("Resiliency: Checks endpoints BPF programs remain loaded")

@aanm
report endpoint ID on endpoint BPF program
76f7d20 
Presenting only the endpoint interface name into the logs might not be
enough to understand which endpoint has the problem. Thus, we should
print the endpoint ID well.

Fixes: d93659c ("Resiliency: Checks endpoints BPF programs remain loaded")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Oct 23, 2023
@aanm aanm requested a review from a team as a code owner October 23, 2023 18:35
@aanm aanm requested a review from danehans October 23, 2023 18:35
@aanm
Copy link
Member Author

aanm commented Oct 23, 2023

/test

@christarazi christarazi added resiliency Tracks resiliency issues area/daemon Impacts operation of the Cilium daemon. labels Oct 25, 2023
christarazi
christarazi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen this logic actually triggering? It should be extremely rare, so I'm asking because it might be finding false positives.

@aanm aanm merged commit bfc805e into cilium:main Oct 25, 2023
61 of 63 checks passed
@aanm aanm deleted the pr/fix-bug-watchdog branch October 25, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@danehans danehans Awaiting requested review from danehans danehans is a code owner automatically assigned from cilium/sig-agent

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. release-note/misc This PR makes changes that have no direct user impact. resiliency Tracks resiliency issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanm @christarazi