Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lb-ipam.rst #28756

Merged
merged 1 commit into from Dec 1, 2023
Merged

Update lb-ipam.rst #28756

merged 1 commit into from Dec 1, 2023

Conversation

nvibert
Copy link
Contributor

@nvibert nvibert commented Oct 24, 2023

Minor update to the documentation. Several users are confused after configuring LB-IPAM and expect L2 announcements to work straight-away.

Clarified the wording so that folks understand they either need to use BGP or L2 Announcement to advertise the IP addresses set by LB-IPAM accordingly.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 24, 2023
@nvibert nvibert marked this pull request as ready for review October 24, 2023 12:01
@nvibert nvibert requested a review from a team as a code owner October 24, 2023 12:01
learnitall
learnitall approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Oct 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2023
@nvibert
Update lb-ipam.rst
99e6897 
Signed-off-by: Nico Vibert <nicolas.vibert@isovalent.com>
@nvibert nvibert requested a review from a team as a code owner November 21, 2023 18:33
@mhofstetter
Copy link
Member

/test

@mhofstetter
Copy link
Member

mhofstetter commented Nov 30, 2023 •
edited

Adding ready-to-merge: all approvals are in and docs change only (/tests didn't skip ci-ipsec-e2e & ipv6 properly)

@mhofstetter mhofstetter added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. feature/lb-ipam labels Nov 30, 2023
@youngnick youngnick merged commit dc9b7c9 into cilium:main Dec 1, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. feature/lb-ipam ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nvibert @mhofstetter @dylandreimerink @ysksuzuki @learnitall @youngnick