Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: introduce gateway api cell #28785

Merged
merged 1 commit into from Oct 27, 2023
Merged

operator: introduce gateway api cell #28785

merged 1 commit into from Oct 27, 2023

Conversation

mhofstetter
Copy link
Member

This commit moves the Gateway API controller registration from the legacyOnLeader cell to its own cell.

In addition, the config properties enable-gateway-api-secrets-sync & gateway-api-secrets-namespace are moved from the global operator config to a dedicate gatewayApiConfig struct.

@mhofstetter mhofstetter added kind/enhancement This would improve or streamline existing functionality. area/operator Impacts the cilium-operator component release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh area/modularization feature/k8s-gateway-api labels Oct 25, 2023
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review October 25, 2023 14:21
@mhofstetter mhofstetter requested review from a team as code owners October 25, 2023 14:21
sayboras
sayboras approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

operator/pkg/gateway-api/cell.go Outdated Show resolved Hide resolved
@mhofstetter mhofstetter mentioned this pull request Oct 26, 2023
Merged
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/operator-gatewayapi-cell branch from f3cd727 to 88dc526 Compare October 26, 2023 09:52
pippolo84
pippolo84 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!
I've left a suggestion for a follow up PR inline.

operator/pkg/gateway-api/cell.go Show resolved Hide resolved
@mhofstetter mhofstetter removed the request for review from meyskens October 26, 2023 11:21
@mhofstetter
Copy link
Member Author

removed review request from @meyskens as @sayboras already covered cilium/sig-servicemesh

@mhofstetter
Copy link
Member Author

/test

@mhofstetter
operator: introduce gateway api cell
a5827f4 
This commit moves the Gateway API controller registration from the
legacyOnLeader cell to its own cell.

In addition, the config properties `enable-gateway-api-secrets-sync` &
`gateway-api-secrets-namespace` are moved from the global operator config
to a dedicate gatewayApiConfig struct.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/operator-gatewayapi-cell branch from 88dc526 to a5827f4 Compare October 26, 2023 11:42
@mhofstetter
Copy link
Member Author

mhofstetter commented Oct 26, 2023 •
edited

rebased to main as gateway api conformance test check was failing -> #28654 added an additional gRPC test (file was missing)

@mhofstetter
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 26, 2023
@sayboras sayboras merged commit bec47c5 into cilium:main Oct 27, 2023
61 of 62 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/operator-gatewayapi-cell branch October 27, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pippolo84 pippolo84 pippolo84 approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/modularization area/operator Impacts the cilium-operator component area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhofstetter @pippolo84 @sayboras