pkg/allocator: Improve 'Key allocation attempt failed' handling for C… #28810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/bug
|
/test |
aanm
force-pushed
the
pr/fix-key-allocator-attempt-error
branch
from
fb3a9f8
to
c271b4b
Compare
|
/test |
giorio94
reviewed
Oct 27, 2023
aanm
force-pushed
the
pr/fix-key-allocator-attempt-error
branch
from
c271b4b
to
7a3f044
Compare
|
/test |
giorio94
reviewed
Oct 30, 2023
…RD mode In CRD mode, the Cilium agent uses CRD to create identities. After an identity is created, the agent acquires a reference for that key. This involves fetching the CRD from the local Kubernetes cache and checking for an annotation applied by cilium-operator to mark the identity for deletion. However, there may be a delay before the Cilium Identity is cached locally, leading to the 'Key allocation attempt failed' error. This patch ensures that we fallback to the newly allocated Cilium Identity if it's not found in the Kubernetes cache. Signed-off-by: André Martins <andre@cilium.io>
We don't need to always DeepCopy Cilium Identity. We just need to perform that operation if we are going perform writes. Signed-off-by: André Martins <andre@cilium.io>
Renamed 'slave' to 'secondary' in the error messages that are presented to users. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-key-allocator-attempt-error
branch
from
7a3f044
to
ee9ce2c
Compare
Idk TBH, the "created" flag doesn't provide the state which is also what I was going for. Have in mind that although it's storing the entire CI object, that Key will be GC since it's only used here. |
|
/test |
Yeah, I saw that it is currently not stored anywhere. I was just a bit concerned that at a certain point we start storing it for other reasons, and we end up with bloated objects. Mostly curiosity though, makes sense as approach to me given the current structure. |
giorio94
approved these changes
Oct 30, 2023
joamaki
approved these changes
Oct 30, 2023
nathanjsweet
approved these changes
Oct 31, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
added
backport/author
aanm
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.4
aanm
added
the
backport/author
github-actions
bot
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.4
julianwiedmann
added
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…RD mode
In CRD mode, the Cilium agent uses CRD to create identities. After an identity is created, the agent acquires a reference for that key. This involves fetching the CRD from the local Kubernetes cache and checking for an annotation applied by cilium-operator to mark the identity for deletion. However, there may be a delay before the Cilium Identity is cached locally, leading to the 'Key allocation attempt failed' error. This patch ensures that we fallback to the newly allocated Cilium Identity if it's not found in the Kubernetes cache.
Fixes #11487