operator: introduce cec l7 envoy loadbalancing cell #28835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/enhancement
|
/test |
mhofstetter
commented
Oct 27, 2023
| @@ -22,7 +21,7 @@ func StartCECController(ctx context.Context, clientset k8sClient.Clientset, serv | |||
| log.WithError(err).Fatal("Failed to retrieve service store") | |||
| } | |||
|
|
|||
| m, err := ciliumenvoyconfig.New(ctx, clientset, store.CacheStore(), ports, defaultAlgorithm, idleTimeoutSeconds) | |||
There was a problem hiding this comment.
"as is" migration without optimizing this further. leaving this for a follow up PR. either by optimizing current approach or going with controller-runtime
sayboras
approved these changes
Oct 27, 2023
😄 it's the last one for sig-servicemesh (within |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
All tests have passed except "netlify/docs-cilium-io/deploy-preview". I'm closing and opening the PR to trigger it and see if it passes since the current failure looks like it was a flake. |
|
@mhofstetter it looks that it didn't work, can you push force again? Thanks |
aanm
removed
the
ready-to-merge
This commit moves the l7 loadbalancing registration from the legacyOnLeader cell into its own cell. In addition, the corresponding config properties have been moved into its own config struct where possible. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit removes the unused fields `maxRetries` & `idleTimeoutSeconds` from the EnvoyConfigManager. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/operator-cec-cell
branch
from
bbec898
to
f3b4abf
Compare
|
rebased to |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the L7 loadbalancing registration from the
legacyOnLeadercell into its own cell.In addition, the corresponding config properties have been moved into its own config struct where possible.