pkg/k8s: do not perform an early return on ipcache errors #28840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
release-note/bug
|
/test |
joestringer
approved these changes
Oct 27, 2023
joestringer
reviewed
Oct 27, 2023
joamaki
approved these changes
Oct 30, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
aanm
force-pushed
the
pr/fix-ipcache-early-return-error
branch
2 times, most recently
from
3b0faf1
to
51e0594
Compare
Although ipcache might return an error, we should not perform an early return in the event handling of the pod event because some other components that are unrelated to ipcache might depend on this specific event per perform correctly. Instead we will log the ipcache error and let the execution of the method to continue. The pod might, for example, be in a "Pending" state which has its status IP addresses not set but might be able to change labels in the meanwhile which Cilium should react upon those changes which are not related with ipcache. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-ipcache-early-return-error
branch
from
51e0594
to
a0777d1
Compare
|
/test |
aanm
removed
the
ready-to-merge
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.4
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although ipcache might return an error, we should not perform an early
return in the event handling of the pod event because some other
components that are unrelated to ipcache might depend on this specific
event per perform correctly. Instead we will log the ipcache error and
let the execution of the method to continue.
The pod might, for example, be in a "Pending" state which has its
status IP addresses not set but might be able to change labels in the
meanwhile which Cilium should react upon those changes which are not
related with ipcache.