Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ec2 eni limits #28880

Merged
merged 1 commit into from Oct 31, 2023
Merged

update ec2 eni limits #28880

merged 1 commit into from Oct 31, 2023

Conversation

michaelsaah
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc

updates ENI limits per the script

ideally this can be backported to 1.13, or at the very least 1.14 - we have a desire for r7gd's on a certain project and this is blocking that at the moment

thanks!

Update ec2 eni limits - current as of Oct 30, 2023

@michaelsaah michaelsaah requested a review from a team as a code owner October 30, 2023 22:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 30, 2023
@michaelsaah
update ec2 eni limits
276fc2b 
updated as per script run today, Oct 30, 2023

Signed-off-by: Michael Saah <msaah@twilio.com>
@christarazi christarazi added area/operator Impacts the cilium-operator component area/eni Impacts ENI based IPAM. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM area/ipam Impacts IP address management functionality. labels Oct 31, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 31, 2023
@christarazi
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 31, 2023
@aanm aanm merged commit 73e7f19 into cilium:main Oct 31, 2023
62 checks passed
@michaelsaah
Copy link
Contributor Author

@christarazi any chance this can be backported into the next 1.14 patch release?

@jeremych1000 jeremych1000 mentioned this pull request Nov 8, 2023
Closed
@AnishShah AnishShah mentioned this pull request Jan 22, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/eni Impacts ENI based IPAM. area/ipam Impacts IP address management functionality. area/operator Impacts the cilium-operator component kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelsaah @christarazi @aanm