bgpv1: Use specific log message and remove unused parameter #28895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
rastislavs
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rastislavs
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
rastislavs
added
kind/cleanup
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
hargrovee
force-pushed
the
use-more-specific-log-message-and-remove-unused-parameter
branch
from
22fdd04
to
4a80fa4
Compare
|
/test |
aanm
removed
the
ready-to-merge
maintainer-s-little-helper
bot
added
the
ready-to-merge
hargrovee
changed the title
hargrovee
force-pushed
the
use-more-specific-log-message-and-remove-unused-parameter
branch
5 times, most recently
from
f71f4ca
to
a691162
Compare
|
@hargrovee please do not force-push if you are not making any further changes, it does not help to move this forward very much, as we need to re-run the tests again after each force-push. |
|
/test |
aanm
removed
the
ready-to-merge
|
@rastislavs Okay, I thought some failed checks might be resolved through a rebase. Thank you for the reminder. |
yeah, sometimes it may help, but looking at the failures it is not the case here. It seems that test have issues when connecting to external targets (1.1.1.1), which seems to be unreliable today, so maybe we should just give it some time and retry later. |
Okay, got it. Thanks！ |
This commit doesn't introduce any functional changes; it's solely about modifications related to log messages and parameters. Specifically: 1. In the diff(), when calling registerOrReconcileDiff and withdrawDiff, more specific log messages can be used. 2. In the withdrawDiff(), the `policy` parameter is not used and can be safely removed. 3. Additionally, withdrawDiff() is actually populating the `withdraw` field of reconcileDiff, while reconcileDiff doesn't have a `remove` field. Signed-off-by: Huagong Wang <wanghuagong@kylinos.cn>
hargrovee
force-pushed
the
use-more-specific-log-message-and-remove-unused-parameter
branch
from
a691162
to
39e10c4
Compare
|
/test |
rastislavs
added
the
ready-to-merge
hargrovee
deleted the
use-more-specific-log-message-and-remove-unused-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit doesn't introduce any functional changes; it's solely about modifications related to log messages and parameters. Specifically:
policyparameter is not used and can be safely removed.withdrawfield of reconcileDiff, while reconcileDiff doesn't have aremovefield.