ipsec: Remove dead code for IPsec node encryption #28898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/encryption
pchaigno
force-pushed
the
remove-ipsec-node-encryption-code
branch
from
482fda0
to
1647c49
Compare
Node encryption for IPsec hasn't been supported since 1d2674d ("docs: ipsec: remove node-to-node encryption") and subsequent commits. The feature also wasn't working since several releases. This commit simply removes the code for that feature. This code has no use now and makes changes to IPsec slightly more difficult. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
force-pushed
the
remove-ipsec-node-encryption-code
branch
from
1647c49
to
66261a7
Compare
|
/test |
Do you mean the flag? It's still used for WireGuard node encryption. |
jschwinger233
approved these changes
Nov 2, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
pchaigno
removed
the
ready-to-merge
maintainer-s-little-helper
bot
added
the
ready-to-merge
pchaigno
added
dont-merge/bad-bot
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.4
jibi
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.9
github-actions
bot
added
backport-done/1.13
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node encryption for IPsec hasn't been supported since 1d2674d ("docs: ipsec: remove node-to-node encryption") and subsequent commits. The feature also wasn't working since several releases.
This commit simply removes the code for that feature. This code has no use now and makes changes to IPsec slightly more difficult.
Commit 1d2674d was merged in v1.12 so I marked this code removal for backports to v1.13 and v1.14 to simplify backports there as well.