New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: xdp: don't support GENEVE passthrough with DSR-Hybrid #28959
Merged
julianwiedmann
merged 1 commit into
cilium:main
from
julianwiedmann:1.15-bpf-xdp-passthrough-hybrid
Nov 9, 2023
Merged
bpf: xdp: don't support GENEVE passthrough with DSR-Hybrid #28959
julianwiedmann
merged 1 commit into
cilium:main
from
julianwiedmann:1.15-bpf-xdp-passthrough-hybrid
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
kind/bug
This is a bug in the Cilium logic.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
area/loadbalancing
Impacts load-balancing and Kubernetes service implementations
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Nov 3, 2023
/test |
/test |
tail_nodeport_nat_egress_ipv4() doesn't have any support for XDP passthrough yet. See encap_geneve_dsr_opt4() for what would be needed to rewrite the outer headers. We also haven't considered how the reply traffic for non-DSR connections would get handled in the LB. Therefore limit the encap-detection to full-DSR. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-bpf-xdp-passthrough-hybrid
branch
from
November 4, 2023 06:12
13f6fb0
to
1649229
Compare
/test |
gentoo-root
reviewed
Nov 8, 2023
gentoo-root
approved these changes
Nov 9, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Nov 9, 2023
gandro
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Nov 15, 2023
github-actions
bot
added
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
and removed
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
labels
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/loadbalancing
Impacts load-balancing and Kubernetes service implementations
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
kind/bug
This is a bug in the Cilium logic.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tail_nodeport_nat_egress_ipv4() doesn't have any support for XDP passthrough yet. See encap_geneve_dsr_opt4() for what would be needed to rewrite the outer headers. We also haven't considered how the reply traffic for non-DSR connections would get handled in the LB.
Therefore limit the encap-detection to full-DSR.