Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: xdp: don't support GENEVE passthrough with DSR-Hybrid #28959

Merged

Conversation

julianwiedmann
Copy link
Member

tail_nodeport_nat_egress_ipv4() doesn't have any support for XDP passthrough yet. See encap_geneve_dsr_opt4() for what would be needed to rewrite the outer headers. We also haven't considered how the reply traffic for non-DSR connections would get handled in the LB.

Therefore limit the encap-detection to full-DSR.

@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/bug This PR fixes an issue in a previous release of Cilium. area/loadbalancing Impacts load-balancing and Kubernetes service implementations needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Nov 3, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
Copy link
Member Author

/test

tail_nodeport_nat_egress_ipv4() doesn't have any support for XDP
passthrough yet. See encap_geneve_dsr_opt4() for what would be needed to
rewrite the outer headers. We also haven't considered how the reply traffic
for non-DSR connections would get handled in the LB.

Therefore limit the encap-detection to full-DSR.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review November 4, 2023 08:05
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 4, 2023 08:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 9, 2023
@julianwiedmann julianwiedmann merged commit 496e240 into cilium:main Nov 9, 2023
61 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-xdp-passthrough-hybrid branch November 9, 2023 15:33
@thorn3r thorn3r added this to Needs backport from main in 1.14.5 Nov 9, 2023
@thorn3r thorn3r removed this from Needs backport from main in 1.14.4 Nov 9, 2023
@gandro gandro mentioned this pull request Nov 15, 2023
6 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.14 in 1.14.4 Nov 15, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.4 Nov 16, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.14 in 1.14.5 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.14.5
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

3 participants