gateway-api: improve secret sync resiliency #29017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/enhancement
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/gateway-api-secret-sync
branch
from
e71ac5f
to
6ed8e0a
Compare
|
/test |
1 similar comment
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/gateway-api-secret-sync
branch
from
6ed8e0a
to
f066116
Compare
This commit removes the predicate option when watching Secrets in the secret-syncer. Without this change we miss to reconcile when: * the synced secret (in NS cilium-secrets) gets deleted or updated * the source secret gets deleted and might no longer be referenced by a Gateway resource Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit restricts the Gateway API's secret sync `For` watch to the source secrets that are outside of the target secrets namespace. This way, already synced secrets aren't re-synced (endless-reconciliation). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
|
updated the test-fixtures |
mhofstetter
force-pushed
the
pr/mhofstetter/gateway-api-secret-sync
branch
from
f066116
to
6b9a46b
Compare
|
/test after rebasing to |
meyskens
approved these changes
Nov 10, 2023
Currently, Gateway API secret sync reconciliation isn't triggered when a synced k8s Secret in the secrets namespace (defaults to `cilium-secrets`) gets deleted or updated. Therefore, this commit introduces an additional watcher that watches for updated & deleted secrets and triggers a reconciliation of the owning Secret by using the labels `io.cilium.gateway/owning-secret-namespace` & `io.cilium.gateway/owning-secret-name` on the synced Secret. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit moves the controller-check (whether a Gateway is managed by Cilium Operator) from the Predicate into the EventHandler. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit unexports the fields `client`, `scheme` & `secretsNamespace` from the type `secretSyncer`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit refactors the Gateway API Secret Sync to handle deleted source secrets. Whenever a Secret gets deleted, the corresponding synced secret gets deleted too. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit refactors the Gateway API Secret Sync reconciler to take the referencing Gateway TLS secret references into account. Meaning that a Secret only gets synced once its referenced by a Gateway resource that is managed by Cilium. In addition, the synced secrets gets deleted once the last reference is deleted. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit introduces a unit test for the secret-sync reconcilation. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/gateway-api-secret-sync
branch
from
6b9a46b
to
b90c021
Compare
|
Addressed @meyskens input - Thanks for the review! |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the resiliency of the Gateway API secret sync.
main changes:
Please review the individual commits.
This is a preparation to re-use the secret synchronization for Cilium Ingress (#28911)