policy: Return a real nil rather than a non-nil interface #29022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callers of lookupOrCreate() test the return value for nilness, but for that to succeed it needs to return nil rather than a nil pointer cast to the SelectorPolicy interface. This came up in an integration test development, there are no know cases of this being a problem in production. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
kind/bug
jrajahalme
added
the
sig/policy
|
/test |
nathanjsweet
approved these changes
Nov 7, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
nathanjsweet
added
affects/v1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers of lookupOrCreate() test the return value for nilness, but for that to succeed it needs to return nil rather than a nil pointer cast to the SelectorPolicy interface.
This came up in an integration test development, there are no know cases of this being a problem in production.