Remove deprecated tunnel option, and corresponding helm values setting #29053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
kind/cleanup
giorio94
force-pushed
the
pr/giorio94/main/remove-deprecated-tunnel-option
branch
from
c3c71a4
to
5c3aa83
Compare
giorio94
force-pushed
the
pr/giorio94/main/remove-deprecated-tunnel-option
branch
from
5c3aa83
to
09471b7
Compare
|
/test |
giorio94
force-pushed
the
pr/giorio94/main/remove-deprecated-tunnel-option
branch
from
09471b7
to
8d22e69
Compare
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This setting was deprecated in Cilium 1.14, replaced by routingMode and tunnelProtocol, and it is going to be dropped in a subsequent commit. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This setting was deprecated in Cilium 1.14, replaced by routingMode and tunnelProtocol, and it is going to be dropped in a subsequent commit. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This setting was deprecated in Cilium 1.14, replaced by routingMode and tunnelProtocol, and it is going to be dropped in a subsequent commit. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This option was deprecated in v1.14, and is superseded by the --routing-mode and --tunnel-protocol options. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
This option was deprecated in v1.14, and is superseded by the routingMode and tunnelProtocol options. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/remove-deprecated-tunnel-option
branch
from
8d22e69
to
43c2f9b
Compare
|
/test |
giorio94
requested review from
markpash,
tklauser,
tommyp1ckles,
nebril,
ysksuzuki,
qmonnet and
viktor-kurchenko
tklauser
approved these changes
Nov 9, 2023
nebril
approved these changes
Nov 9, 2023
ysksuzuki
approved these changes
Nov 9, 2023
tommyp1ckles
approved these changes
Nov 10, 2023
viktor-kurchenko
approved these changes
Nov 10, 2023
|
Reviews from all code owners are in, tests are green (except for one of the Cilium IPsec upgrade matrix entries, which is unrelated from this PR, and known to be flaky). Marking as ready to merge |
giorio94
added
the
ready-to-merge
tklauser
deleted the
pr/giorio94/main/remove-deprecated-tunnel-option
branch
maintainer-s-little-helper
bot
removed
ready-to-merge
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --tunnel option was deprecated in v1.14 [1], and is superseded by the --routing-mode and --tunnel-protocol options.
[1]: #24561