Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-ipsec-upgrade: Fix upgrade/downgrade path and add missed tail calls check to upgrade #29072

Merged
merged 2 commits into from Nov 9, 2023
Merged

ci-ipsec-upgrade: Fix upgrade/downgrade path and add missed tail calls check to upgrade #29072

merged 2 commits into from Nov 9, 2023

Conversation

brb
Copy link
Member

@brb brb commented Nov 9, 2023

No description provided.

@brb
ci-ipsec-upgrade: Use branch tip instead of released version
ed76e0e 
[1] changed the upgrade path from "v1.14 (branch tip) -> main -> v1.14
(branch tip)" to "v1.14.x (last release) -> main -> v1.14.x (last
release)". The downside of the former path is that we catch any
upgrade/downgrade regressions only after a release.

This commit brings back the previous path.

[1]: 31afd02

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
ci-ipsec-upgrade: Add missed tail calls check for upgrade
95b7914 
The downgrade is still affected [1].

[1]: #26739 (comment)

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 9, 2023
@brb brb requested review from a team as code owners November 9, 2023 08:38
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.16 Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.9 Nov 9, 2023
@brb
Copy link
Member Author

brb commented Nov 9, 2023

/ci-ipsec-upgrade

jschwinger233
jschwinger233 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 9, 2023
@pchaigno pchaigno merged commit ced884f into main Nov 9, 2023
50 checks passed
@pchaigno pchaigno deleted the pr/brb/ci-ipsec-upgrade-tip-n-missed-tl-calls branch November 9, 2023 10:24
@qmonnet qmonnet added the backport/author The backport will be carried out by the author of the PR. label Nov 9, 2023
@qmonnet
Copy link
Member

qmonnet commented Nov 9, 2023

I'll take care of backports as part of my own work on the workflow. Gray's commit hasn't been backported yet anyway.

This was referenced Nov 9, 2023
Merged
Merged
Merged
@qmonnet qmonnet added backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.4 Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.4 Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.9 Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.9 Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.16 Nov 9, 2023
@nathanjsweet nathanjsweet moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.16 Nov 10, 2023
@nathanjsweet nathanjsweet removed this from Backport done to v1.12 in 1.12.16 Nov 10, 2023
@nathanjsweet nathanjsweet added this to Backport pending to v1.12 in 1.12.17 Nov 10, 2023
@nathanjsweet nathanjsweet added this to Needs backport from main in 1.13.10 Nov 12, 2023
@nathanjsweet nathanjsweet removed this from Backport pending to v1.13 in 1.13.9 Nov 12, 2023
@nathanjsweet nathanjsweet moved this from Needs backport from main to Backport pending to v1.13 in 1.13.10 Nov 12, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.13 in 1.13.9 Nov 28, 2023
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Nov 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.13 in 1.13.9 Nov 28, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.4 Nov 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.13 in 1.13.9 Nov 28, 2023
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
@nebril nebril moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.10 Dec 11, 2023
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
@nebril nebril moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.17 Dec 11, 2023
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@viktor-kurchenko viktor-kurchenko Awaiting requested review from viktor-kurchenko viktor-kurchenko is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport/author The backport will be carried out by the author of the PR. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.12.17
Backport done to v1.12
1.13.10
Backport done to v1.13
1.13.9
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brb @qmonnet @pchaigno @jschwinger233