Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security, node and affinity values to SPIRE agent #29077

Merged
merged 1 commit into from Nov 14, 2023
Merged

Add security, node and affinity values to SPIRE agent #29077

merged 1 commit into from Nov 14, 2023

Conversation

meyskens
Copy link
Member

@meyskens meyskens commented Nov 9, 2023 •
edited

This adds affinity, nodeSelector, podSecurityContext and securityContext to the values for the agent installation of SPIRE. These were previously only on the server.

Adds affinity, nodeSelector, podSecurityContext and securityContext to the SPIRE agent deployment values

@meyskens meyskens requested review from a team as code owners November 9, 2023 10:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 9, 2023
@meyskens meyskens added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Nov 9, 2023
@meyskens meyskens added area/servicemesh GH issues or PRs regarding servicemesh feature/authentication labels Nov 9, 2023
gandro
gandro approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm LGTM!

mhofstetter
mhofstetter approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As this PR is only adding affinity, nodeSelector & securityContext, we should remove tolerations from the release note message and the PR description. (And maybe even the commit message if you have to re-push)

@meyskens meyskens force-pushed the meyskens/spire-agent-ds-values branch from 64d9d3e to ed73b32 Compare November 9, 2023 13:32
@meyskens
Copy link
Member Author

meyskens commented Nov 9, 2023

I copied one too much when writing the description, fixed the commit description

@thorn3r thorn3r added this to Needs backport from main in 1.14.5 Nov 9, 2023
@thorn3r thorn3r removed this from Needs backport from main in 1.14.4 Nov 9, 2023
tommyp1ckles
tommyp1ckles approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just some minor comments to cleanup.

@meyskens
Add security, node and affinity values to SPIRE agent
d2b36c2 
This adds affinity, nodeSelector, podSecurityContext and
securityContext to the values for the agent installation of SPIRE.
These were previously only on the server.

Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
@meyskens meyskens force-pushed the meyskens/spire-agent-ds-values branch from ed73b32 to d2b36c2 Compare November 13, 2023 15:42
@meyskens
Copy link
Member Author

/test

@meyskens meyskens closed this Nov 14, 2023
@meyskens meyskens reopened this Nov 14, 2023
@meyskens
Copy link
Member Author

All reviews are in and approved, all tests passed, setting ready to merge as MLH seems to skip it

@meyskens meyskens added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Nov 14, 2023
@julianwiedmann
Copy link
Member

@meyskens I would love to press the green button, but GH says no 🙀 .

This branch cannot be rebased safely
Rebasing the commits of this branch on top of the base branch cannot be performed automatically as this would create a different result than a regular merge.

can you try to rebase manually?

@meyskens
Copy link
Member Author

@julianwiedmann ooooof.... it all says green here :/ I will rebase locally

@julianwiedmann julianwiedmann merged commit e365f14 into cilium:main Nov 14, 2023
101 checks passed
@meyskens meyskens deleted the meyskens/spire-agent-ds-values branch November 14, 2023 15:14
@meyskens meyskens restored the meyskens/spire-agent-ds-values branch November 14, 2023 15:15
@meyskens meyskens deleted the meyskens/spire-agent-ds-values branch November 14, 2023 15:15
@julianwiedmann
Copy link
Member

@julianwiedmann ooooof.... it all says green here :/ I will rebase locally

You saying "green" was all it needed, apparently? Amazing technology.

@gandro gandro mentioned this pull request Nov 15, 2023
Merged
6 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.4 Nov 15, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.4 Nov 16, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.14 in 1.14.5 Dec 11, 2023
@nebril nebril mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/authentication ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.14.5
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@meyskens @julianwiedmann @gandro @tommyp1ckles @mhofstetter