docs: add instructions to build kindest-node image #29079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
area/documentation
aanm
force-pushed
the
pr/add-nodes-for-kind-upgrade
branch
from
c7eddff
to
c308c99
Compare
qmonnet
requested changes
Nov 9, 2023
|
|
||
| make -C images/base/ quick | ||
|
|
||
| Note the resulting image tag for that command, it should be last tag built for |
There was a problem hiding this comment.
Suggested change
| Note the resulting image tag for that command, it should be last tag built for | |
| Note the resulting image tag for that command, it should be the last tag built for |
How do you check the tags for the repository? Would it make sense to turn it into a URL (https://gcr.io/k8s-staging-kind/base)?
There was a problem hiding this comment.
I've changed it to:
Take note of the resulting image tag for that command, it should be the last
tag built for the ``gcr.io/k8s-staging-kind/base`` repository in ``docker ps -a``.
Add instructions on how to update kindest-node image so that others can also perform this tasks if necessary. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/add-nodes-for-kind-upgrade
branch
from
c308c99
to
46984e2
Compare
|
/test |
tommyp1ckles
approved these changes
Nov 9, 2023
bimmlerd
approved these changes
Nov 10, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions on how to update kindest-node image so that others can also perform this tasks if necessary.