Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: use l4_load_ports() everywhere #29135

Merged
merged 1 commit into from Nov 14, 2023
Merged

bpf: use l4_load_ports() everywhere #29135

merged 1 commit into from Nov 14, 2023

Conversation

julianwiedmann
Copy link
Member

Clean up all remaining open-coded occurences. No functional change, but this clarifies intent and should make it easier to spot areas that currently don't handle IPv4 fragmentation.

@julianwiedmann
bpf: use l4_load_ports() everywhere
9f88d14 
Clean up all remaining open-coded occurences. No functional change, but
this clarifies intent and should make it easier to spot areas that
currently don't handle IPv4 fragmentation.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Nov 13, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review November 13, 2023 15:48
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 13, 2023 15:48
gentoo-root
gentoo-root approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@gentoo-root gentoo-root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

bpf/lib/proxy.h Show resolved Hide resolved
bpf/lib/ipv4.h Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@julianwiedmann julianwiedmann merged commit 61f0e84 into cilium:main Nov 14, 2023
62 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-bpf-frag-follow-ons branch November 14, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @gentoo-root