Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: fix up for import rename #29143

Merged
merged 1 commit into from Nov 13, 2023
Merged

gateway-api: fix up for import rename #29143

merged 1 commit into from Nov 13, 2023

Conversation

julianwiedmann
Copy link
Member

Fix up a conflict with
0b36119 ("gateway-api: Update import name in unit test").

@julianwiedmann
gateway-api: fix up for import rename
3e8dfe2 
Fix up a conflict with
0b36119 ("gateway-api: Update import name in unit test").

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api labels Nov 13, 2023
@julianwiedmann julianwiedmann mentioned this pull request Nov 13, 2023
Merged
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review November 13, 2023 19:00
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 13, 2023 19:00
sayboras
sayboras approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM ✔️

@joestringer joestringer merged commit 93f26fd into cilium:main Nov 13, 2023
59 of 62 checks passed
@julianwiedmann julianwiedmann deleted the 1.15-gateway-test branch November 14, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@meyskens meyskens Awaiting requested review from meyskens meyskens is a code owner automatically assigned from cilium/sig-servicemesh

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @sayboras @joestringer