devices: fix busy loop #29163
Merged
devices: fix busy loop #29163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If previous devices and new devices are equal, we don't wait for the invalidation of the query, and run into a busy loop until the devices change. Fixes: 03ad61b (datapath/linux: Implement DevicesController) Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
added
kind/bug
|
/test |
|
CI triage:
|
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If previous devices and new devices are equal, we don't wait for the invalidation of the query, and run into a busy loop until the devices change.
Fixes: 03ad61b (datapath/linux: Implement DevicesController) @joamaki - I've mentioned the bug to Jussi (who's on PTO atm), he agrees it's a bug, hence not pulling him in for review.
AFAIK this was never in a release thus not marking this a
release-note/bug, but happy to be corrected on that.