New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOLed Kubernetes versions #29174
Conversation
7711c52
to
2e9069b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
/test |
i'll bring this up in the community meeting today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To accept the PR we should do a couple more things:
- Document our testing criteria in the documentation, under Documentation/network/kubernetes/compatibility.rst and Documentation/network/kubernetes/requirements.rst should be fine
- Keep the list of cloud provider k8s versions that we test in the list on those files.
- Making sure that by removing the k8s versions that we aren't dropping testing on specific kernel versions. For example, kernel 4.19 is only tested with k8s 1.19 so if we are dropping it then we need to change the test of 4.19 to be 1.26. That's defined in .github/actions/ginkgo/main-k8s-versions.yaml.
thanks for the feedback andre, i'll update the docs. regarding the kernel version, don't we also test 4.19 with k8s 1.27? https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-k8s-versions.yaml#L11-L16 |
back to draft to address feedback |
8aa8fac
to
675650f
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there's one bullet point missing:
Making sure that by removing the k8s versions that we aren't dropping testing on specific kernel versions. For example, kernel 4.19 is only tested with k8s 1.19 so if we are dropping it then we need to change the test of 4.19 to be 1.26. That's defined in .github/actions/ginkgo/main-k8s-versions.yaml.
thanks @aanm, yeah this is the part i wasn't sure about. don't we already test 4.19 with 1.27, or am i reading this wrong? 💭 https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-k8s-versions.yaml#L11-L16 |
675650f
to
969b43a
Compare
requesting additional review from @joestringer 🚀 🙏 |
/test |
@michi-covalent this file is also relevant https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-focus.yaml. We need to make sure we are removing the sections that are excluded as well as readjust it if necessary. |
Remove EOLed Kubernetes versions from Ginkgo PR and scheduled runs, and update the docs accordingly. Ref: https://kubernetes.io/releases/patch-releases/ Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
969b43a
to
84069f5
Compare
/test |
Remove manifests used in tests against EOLed Kubernetes versions. Ref. #29174 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Remove manifests used in tests against EOLed Kubernetes versions. Ref. #29174 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Remove manifests used in tests against EOLed Kubernetes versions. Ref. cilium#29174 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Remove EOLed Kubernetes versions from Ginkgo PR and scheduled runs, and update the docs accordingly.
Ref: https://kubernetes.io/releases/patch-releases/