Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOLed Kubernetes versions #29174

Merged
merged 1 commit into from Nov 23, 2023
Merged

Conversation

michi-covalent
Copy link
Contributor

Remove EOLed Kubernetes versions from Ginkgo PR and scheduled runs, and update the docs accordingly.

Ref: https://kubernetes.io/releases/patch-releases/

@michi-covalent michi-covalent requested review from a team as code owners November 14, 2023 23:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 14, 2023
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Nov 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 14, 2023
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent added the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label Nov 15, 2023
@michi-covalent
Copy link
Contributor Author

i'll bring this up in the community meeting today

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To accept the PR we should do a couple more things:

  • Document our testing criteria in the documentation, under Documentation/network/kubernetes/compatibility.rst and Documentation/network/kubernetes/requirements.rst should be fine
  • Keep the list of cloud provider k8s versions that we test in the list on those files.
  • Making sure that by removing the k8s versions that we aren't dropping testing on specific kernel versions. For example, kernel 4.19 is only tested with k8s 1.19 so if we are dropping it then we need to change the test of 4.19 to be 1.26. That's defined in .github/actions/ginkgo/main-k8s-versions.yaml.

@michi-covalent
Copy link
Contributor Author

thanks for the feedback andre, i'll update the docs.

regarding the kernel version, don't we also test 4.19 with k8s 1.27? https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-k8s-versions.yaml#L11-L16

@michi-covalent
Copy link
Contributor Author

back to draft to address feedback

@michi-covalent michi-covalent marked this pull request as draft November 16, 2023 02:38
@michi-covalent michi-covalent force-pushed the pr/michi/eol branch 2 times, most recently from 8aa8fac to 675650f Compare November 16, 2023 03:11
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent removed the dont-merge/discussion A discussion is ongoing and should be resolved before merging, regardless of reviews & tests status. label Nov 16, 2023
@lambdanis lambdanis self-requested a review November 17, 2023 12:06
@michi-covalent michi-covalent marked this pull request as ready for review November 22, 2023 00:56
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there's one bullet point missing:

Making sure that by removing the k8s versions that we aren't dropping testing on specific kernel versions. For example, kernel 4.19 is only tested with k8s 1.19 so if we are dropping it then we need to change the test of 4.19 to be 1.26. That's defined in .github/actions/ginkgo/main-k8s-versions.yaml.

Documentation/network/kubernetes/compatibility.rst Outdated Show resolved Hide resolved
@michi-covalent
Copy link
Contributor Author

Making sure that by removing the k8s versions that we aren't dropping testing on specific kernel versions. For example, kernel 4.19 is only tested with k8s 1.19 so if we are dropping it then we need to change the test of 4.19 to be 1.26. That's defined in .github/actions/ginkgo/main-k8s-versions.yaml.

thanks @aanm, yeah this is the part i wasn't sure about. don't we already test 4.19 with 1.27, or am i reading this wrong? 💭 https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-k8s-versions.yaml#L11-L16

@michi-covalent
Copy link
Contributor Author

requesting additional review from @joestringer 🚀 🙏

@michi-covalent
Copy link
Contributor Author

/test

@aanm
Copy link
Member

aanm commented Nov 22, 2023

Making sure that by removing the k8s versions that we aren't dropping testing on specific kernel versions. For example, kernel 4.19 is only tested with k8s 1.19 so if we are dropping it then we need to change the test of 4.19 to be 1.26. That's defined in .github/actions/ginkgo/main-k8s-versions.yaml.

thanks @aanm, yeah this is the part i wasn't sure about. don't we already test 4.19 with 1.27, or am i reading this wrong? 💭 https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-k8s-versions.yaml#L11-L16

@michi-covalent this file is also relevant https://github.com/cilium/cilium/blob/main/.github/actions/ginkgo/main-focus.yaml. We need to make sure we are removing the sections that are excluded as well as readjust it if necessary.

Remove EOLed Kubernetes versions from Ginkgo PR and scheduled runs, and
update the docs accordingly.

Ref: https://kubernetes.io/releases/patch-releases/

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit c0a5681 Nov 23, 2023
198 checks passed
@michi-covalent michi-covalent deleted the pr/michi/eol branch November 23, 2023 00:43
tklauser added a commit that referenced this pull request Nov 28, 2023
Remove manifests used in tests against EOLed Kubernetes versions.

Ref. #29174

Signed-off-by: Tobias Klauser <tobias@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2023
Remove manifests used in tests against EOLed Kubernetes versions.

Ref. #29174

Signed-off-by: Tobias Klauser <tobias@cilium.io>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
Remove manifests used in tests against EOLed Kubernetes versions.

Ref. cilium#29174

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants