Do not handle mutual auth for reserved ids #29400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
meyskens
added
release-note/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
mhofstetter
reviewed
Nov 29, 2023
joestringer
added
the
needs-backport/1.15
meyskens
force-pushed
the
meyskens/auth-reserved-ids
branch
from
cb94c6e
to
0153826
Compare
mhofstetter
approved these changes
Dec 20, 2023
|
/test |
meyskens
force-pushed
the
meyskens/auth-reserved-ids
branch
from
0153826
to
7444cea
Compare
|
/test |
This change adds a check in the auth manager not to do authentication for either IDs if they are reserved. This could have caused failed handshakes to happen should any of these entities be allowed by policy but with mutual auth enabled. These IDs do are not able to ever complete a handshake as they are not generated by design. This commit also replaces all IDs used in tests to be high enough that they do not conflict with reserve IDs. Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
meyskens
force-pushed
the
meyskens/auth-reserved-ids
branch
from
7444cea
to
4215193
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This was referenced Jan 11, 2024
jibi
added
backport-pending/1.15
gandro
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.6
github-actions
bot
added
backport-done/1.14
giorio94
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a check in the auth manager not to do authentication for either IDs if they are reserved.
This could have caused failed handshakes to happen should any of these entities be allowed by policy but with mutual auth enabled. These IDs do are not able to ever complete a handshake as they are not generated by design.