gateway-api: don't register secretsync if required CRDs aren't present #29437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cilium#28982 a check got introduced that disables the Gateway API functionality if the required Gateway API CRDs aren't installed in the cluster. But this check is not executed when the secret sync registrations is performed. This results in failures in the secret-sync: ``` level=error msg="kind must be registered to the Scheme" error="no kind is registered for the type v1.Gateway in scheme \"k8s.io/client-go/kubernetes/scheme/register.go:80\"" logger=controller-runtime.source.EventHandler subsys=controller-runtime ``` Therefore, this commit adds the check to the secret sync registration too. Fixes: cilium#29100 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/bug
|
/test |
sayboras
approved these changes
Nov 29, 2023
|
Removed @youngnick because @sayboras already covers sig-servicemesh. marking as |
mhofstetter
added
the
ready-to-merge
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #28982 a check got introduced that disables the Gateway API functionality if the required Gateway API CRDs aren't installed in the cluster.
But this check is not executed when the secret sync registrations is performed.
This leads to situations where the CRD isn't registered to the schema, but secretsync registering watches for this CRD. This results in failures in the secret-sync:
Therefore, this commit adds the check to the secret sync registration too.
Fixes: #29100