endpointmanager: unmap ip for lookup #29554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of an IPv4-mapped IPv6 address we'd lookup the address as an
IPv4 address with a ::ffff: prefix, leading to endpoint lookup errors
such as
cannot find endpoint with IP ::ffff:10.0.1.19
Fix this by explicitly unmapping the address before lookup which leads
to 10.0.1.19 to be looked up (and found) in the above case.
Fixes: 54a896c ("endpointmanager: Use netip.Addr instead of net.IP in LookupIP")
Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
release-note/bug
|
/test |
squeed
approved these changes
Dec 4, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
10 tasks
nbusseneau
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an IPv4-mapped IPv6 address we'd lookup the address as an IPv4 address with a ::ffff: prefix, leading to endpoint lookup errors such as
Fix this by explicitly unmapping the address before lookup which leads to 10.0.1.19 to be looked up (and found) in the above case.
Fixes: 54a896c ("endpointmanager: Use netip.Addr instead of net.IP in LookupIP")