Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Allow setting resources for the agent init containers #29610

Merged
merged 1 commit into from Dec 6, 2023
Merged

helm: Allow setting resources for the agent init containers #29610

merged 1 commit into from Dec 6, 2023

Conversation

ayuspin
Copy link
Contributor

@ayuspin ayuspin commented Dec 4, 2023

Allow setting resources for the agent init containers

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 4, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 4, 2023
@maintainer-s-little-helper
Copy link

Commit 6b2e66d does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 5, 2023
@ayuspin ayuspin marked this pull request as ready for review December 5, 2023 12:23
@ayuspin ayuspin requested review from a team as code owners December 5, 2023 12:23
@ayuspin ayuspin marked this pull request as draft December 5, 2023 12:25
@maintainer-s-little-helper
Copy link

Commits 6b2e66d, 67ded39 do not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 5, 2023
@ayuspin ayuspin marked this pull request as ready for review December 5, 2023 15:20
@gandro
Copy link
Member

gandro commented Dec 5, 2023

Thanks for the PR. Please note that the helm README.md also needs to be re-generated: make -C install/kubernetes
https://github.com/cilium/cilium/actions/runs/7102803158/job/19334017163?pr=29610

@gandro gandro added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/helm Impacts helm charts and user deployment experience labels Dec 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 5, 2023
@ayuspin
Copy link
Contributor Author

ayuspin commented Dec 5, 2023

@gandro thank you for looking into this, I regenerated helm README.md as suggested

@sayboras sayboras changed the title helm: allow setting resources for the agent init containers helm: Allow setting resources for the agent init containers Dec 6, 2023
@sayboras
Copy link
Member

sayboras commented Dec 6, 2023

/test

@sayboras sayboras added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.5 Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.10 Dec 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.17 Dec 6, 2023
sayboras
sayboras approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and lgtm ✔️

@sayboras sayboras added this pull request to the merge queue Dec 6, 2023
Merged via the queue into cilium:main with commit de788fa Dec 6, 2023
61 checks passed
@sayboras sayboras removed the backport/author The backport will be carried out by the author of the PR. label Dec 7, 2023
@sayboras sayboras mentioned this pull request Dec 7, 2023
Merged
3 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.5 Dec 7, 2023
@sayboras sayboras mentioned this pull request Dec 7, 2023
Merged
3 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.10 Dec 7, 2023
@sayboras sayboras mentioned this pull request Dec 7, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.17 Dec 7, 2023
@github-actions github-actions bot removed the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.5 Dec 7, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.14 in 1.14.5 Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.13 in 1.13.10 Dec 8, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Dec 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.12 in 1.12.17 Dec 8, 2023
This was referenced Dec 11, 2023
Merged
Merged
Merged
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.14.5
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayuspin @gandro @sayboras @youngnick