Add ServiceMonitor config for Agent Envoy when enabled #30126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
youngnick
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
PhilipSchmid
reviewed
Jan 8, 2024
|
Will we be able to backport this to 1.14? AFAICT, we should, as it's a bug fix for the Helm chart. If so, 🤞 so that we get this into the next January 24 patch release. |
youngnick
added
backport/1.14
youngnick
force-pushed
the
28356-envoy-metrics
branch
2 times, most recently
from
f686a9f
to
10c0e72
Compare
|
I've marked this for backport, it makes sense for me. |
|
/test |
brlbil
approved these changes
Jan 9, 2024
brlbil
approved these changes
Jan 10, 2024
tommyp1ckles
approved these changes
Jan 16, 2024
|
ci-ipsec-upgrade hit #27762. |
|
/ci-ginkgo |
|
Checking to see if it's the same two ginkgo jobs failing. |
|
/ci-ginkgo |
|
the Ginkgo check keeps failling at different steps for different reasons, I'll try one last time |
|
/ci-ginkgo |
This commit adds Prometheus config to scrape Envoy metrics from the Envoy port (default 9964) on the Agent when Envoy is enabled. It uses the newer `.Values.envoy` section of the Helm chart, as we want to emphasize using that config regardless of where Envoy is running (in-agent or in a separate Daemonset). Signed-off-by: Nick Young <nick@isovalent.com>
youngnick
force-pushed
the
28356-envoy-metrics
branch
from
10c0e72
to
2b11269
Compare
|
/test |
|
/ci-e2e |
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
giorio94
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
giorio94
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
michi-covalent
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds Prometheus config to scrape Envoy metrics from the Envoy port (default 9964) on the Agent when Envoy is enabled.
It uses the newer
.Values.envoysection of the Helm chart, as we want to emphasize using that config regardless of where Envoy is running (in-agent or in a separate Daemonset).Fixes: #28356