Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix chained veth plugin example #30209

Merged
merged 1 commit into from Jan 11, 2024
Merged

docs: fix chained veth plugin example #30209

merged 1 commit into from Jan 11, 2024

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Jan 11, 2024 •
edited

We previously looked up the chaining mode by name, but this is non-obvious and unnecessary. So, we added the CNI chaining-mode parameter. But, we failed to update the docs to reference this.

Fixes: #28714

@squeed
docs: fix chained veth plugin example
6fc70b7 
We previously looked up the chaining mode by name, but this is
non-obvious and unnecessary. So, we added the CHI chaining-mode
parameter. But, we failed to update the docs to reference this.

Fixes: cilium#28714

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 11, 2024
@squeed squeed requested a review from a team as a code owner January 11, 2024 15:21
@squeed squeed requested a review from qmonnet January 11, 2024 15:21
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in v1.15.0-rc.1 Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.6 Jan 11, 2024
@qmonnet
Copy link
Member

qmonnet commented Jan 11, 2024

/test

@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 11, 2024
@qmonnet qmonnet added this pull request to the merge queue Jan 11, 2024
Merged via the queue into cilium:main with commit a255997 Jan 11, 2024
60 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 11, 2024
@jibi jibi mentioned this pull request Jan 12, 2024
Merged
32 tasks
@jibi jibi added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in v1.15.0-rc.1 Jan 12, 2024
@gandro gandro mentioned this pull request Jan 16, 2024
Merged
5 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jan 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.6 Jan 16, 2024
@aanm aanm mentioned this pull request Jan 16, 2024
Merged
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jan 17, 2024
@gentoo-root gentoo-root moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.6 Jan 17, 2024
@gentoo-root gentoo-root mentioned this pull request Jan 17, 2024
Merged
@giorio94 giorio94 added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in v1.15.0-rc.1 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.6
Backport done to v1.14
v1.15.0-rc.1
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic Veth Chaining configuration suggested in documentation does not work.
5 participants
@squeed @qmonnet @gandro @jibi @giorio94