Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader, bpf: remove context cancellation check, lower pending map removal Warning to Info #30214

Merged
merged 2 commits into from Jan 11, 2024
Merged

loader, bpf: remove context cancellation check, lower pending map removal Warning to Info #30214

merged 2 commits into from Jan 11, 2024

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jan 11, 2024 •
edited 

loader: ignore context cancellations during map migration

Allowing replaceDatapath() to be cancelled in the middle of an ongoing map
migration is a potential source of chaos. We've recently seen some flakes
with errors like `Removed pending pinned map, did the agent die unexpectedly?`,
so let's remove this context check to reduce the likelyhood of that happening.

bpf: lower pending map removal warning to info level

This has been making ci-ginkgo fail recently. With the removal of map
migrations around the corner (https://github.com/cilium/cilium/issues/29333),
and having declared bankruptcy on the Ginkgo test suite, let's not waste more
time chasing this bugbear.

Contributes to #29350.
Fixes #30101.

@ti-mo
loader: ignore context cancellations during map migration
7368e4a 
Allowing replaceDatapath() to be cancelled in the middle of an ongoing map
migration is a potential source of chaos. We've recently seen some flakes
with errors like `Removed pending pinned map, did the agent die unexpectedly?`,
so let's remove this context check to reduce the likelyhood of that happening.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo
bpf: lower pending map removal warning to info level
084d93d 
This has been making ci-ginkgo fail recently. With the removal of map
migrations around the corner (cilium#29333),
and having declared bankruptcy on the Ginkgo test suite, let's not waste more
time chasing this bugbear.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo requested a review from a team as a code owner January 11, 2024 16:39
@ti-mo ti-mo requested a review from rgo3 January 11, 2024 16:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 11, 2024
@ti-mo ti-mo mentioned this pull request Jan 11, 2024
Closed
@ti-mo
Copy link
Contributor Author

ti-mo commented Jan 11, 2024

/test

@ti-mo ti-mo added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 11, 2024
@ti-mo ti-mo added sig/loader Impacts the loading of BPF programs into the kernel. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 11, 2024
@ti-mo ti-mo added this pull request to the merge queue Jan 11, 2024
Merged via the queue into cilium:main with commit 760a109 Jan 11, 2024
63 checks passed
@ti-mo ti-mo deleted the tb/loader-safe-points branch January 11, 2024 22:21
@mhofstetter mhofstetter mentioned this pull request Jan 12, 2024
Merged
@ti-mo ti-mo added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 18, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in v1.15.0-rc.1 Jan 18, 2024
@ti-mo ti-mo added the backport/author The backport will be carried out by the author of the PR. label Jan 18, 2024
@ti-mo ti-mo mentioned this pull request Jan 18, 2024
Merged
3 tasks
@ti-mo ti-mo added the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Jan 18, 2024
@ti-mo ti-mo removed the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Jan 18, 2024
@ti-mo ti-mo mentioned this pull request Jan 18, 2024
Merged
2 tasks
@ti-mo ti-mo added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jan 18, 2024
@ti-mo ti-mo mentioned this pull request Jan 18, 2024
Merged
2 tasks
@ti-mo ti-mo added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 18, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in v1.15.0-rc.1 Jan 18, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jan 23, 2024
@giorio94 giorio94 added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in v1.15.0-rc.1 Jan 29, 2024
This was referenced Feb 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

@rgo3 rgo3 rgo3 approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport/author The backport will be carried out by the author of the PR. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
No open projects
v1.15.0-rc.1
Backport done to v1.15
Milestone
No milestone
4 participants
@ti-mo @lmb @rgo3 @giorio94