pkg/nodediscovery: Updates updateCiliumNodeResource() Warning Message #30257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, updateCiliumNodeResource() would emit a warning message whenever the k8s client could not get the local CiliumNode resource from the k8s api server. This caused the following benign log message for new installations since the CiliumNode resource has yet to be created: `level=warning msg="Unable to get node resource" error="ciliumnodes.cilium.io \"kind-control-plane\" not found" subsys=nodediscovery` This PR updates updateCiliumNodeResource() to only generate the warning message when the maximum number of attempts has been reached. Fixes: cilium#29330 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
added
the
needs-backport/1.15
joestringer
added
release-note/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
ldelossa
approved these changes
Jan 17, 2024
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
@ldelossa thanks for the review! I have no objection to adding an info-level log message similar to what you suggest if others agree. |
|
@danehans - Lets merge this in right no since it's a release blocker. We can add the extra logging in a subsequent PR. |
giorio94
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in v1.15.0-rc.1
giorio94
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.15
to Backport done to v1.15
in v1.15.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, updateCiliumNodeResource() would emit a warning message whenever the k8s client could not get the local CiliumNode resource from the k8s api server. This caused the following benign log message for new installations since the CiliumNode resource has yet to be created:
level=warning msg="Unable to get node resource" error="ciliumnodes.cilium.io \"kind-control-plane\" not found" subsys=nodediscoveryThis PR updates updateCiliumNodeResource() to only generate the warning message when the maximum number of attempts has been reached.
Fixes: #29330