proxy: fix rule deletion if protocol family is unsupported #30299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
added
kind/bug
|
/test |
danehans
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Consider adding a test case for this by using SocketDisableIPv6.
|
Nice suggestion @danehans, left the PR as a draft because I didn't come up with a regression test yet. I'll give it a shot tomorrow! |
|
Using |
|
@rgo3 thanks for looking into this and providing feedback. /LGTM |
This was referenced Jan 18, 2024
Currently we try to remove IPv6 proxy rules if the IPv6 option is disabled. This is to clean up those rules if a previously running agent has installed them but was restarted with a configuration change. This can fail if the underlying kernel has no IPv6 support. This commit fixes this, by allowing the necessary netlink syscall to fail with EAFNOSUPPORT. Fixes: cilium#29965 Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
rgo3
force-pushed
the
fix-proxy-rule-deletion
branch
from
b4a2006
to
8be61bb
Compare
|
/test |
danehans
approved these changes
Jan 19, 2024
joestringer
added
the
release-blocker/1.15
tommyp1ckles
approved these changes
Jan 24, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
joamaki
added
backport-pending/1.15
aanm
added
backport-done/1.15
michi-covalent
moved this from Needs backport from main
to Backport done to v1.15
in 1.15.1
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we try to remove IPv6 proxy rules if the IPv6 option is disabled. This is to clean up those rules if a previously running agent has installed them but was restarted with a configuration change. This can fail if the underlying kernel has no IPv6 support. This commit fixes this, by allowing the necessary netlink syscall to fail with EAFNOSUPPORT.
Fixes: #29965