gha: make runner type for clustermesh workflows configurable #30496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b20038e ("gha: explicilty specify beefier runner type for clustermesh workflows") explicitly configured beefier runners for clustermesh workflows, as they require more power to host two multi-node kind clusters. However, this change turned out to have unexpected billing consequences, even though GitHub recently upgraded [1] the default runners for OSS projects to 4 vCPU and 16GiB of RAM (the same specs of the runner which had been configured). Hence, let's revert this change, and instead make the runner type configurable through an environment variable. This will also make it easier to change the runner type in the future, if needed. [1]: https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/ Fixes: b20038e ("gha: explicilty specify beefier runner type for clustermesh workflows") Suggested-by: André Martins <andre@cilium.io> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
area/CI
|
/test |
marseel
approved these changes
Jan 29, 2024
christarazi
approved these changes
Jan 29, 2024
aanm
approved these changes
Feb 1, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
deleted the
pr/giorio94/main/gha-clustermesh-configurable-runners
branch
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.12
nbusseneau
added
backport-pending/1.14
12 tasks
nbusseneau
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.7
github-actions
bot
added
backport-done/1.15
github-actions
bot
added
backport-done/1.13
github-actions
bot
added
backport-done/1.12
This was referenced Feb 12, 2024
michi-covalent
moved this from Needs backport from main
to Backport done to v1.15
in 1.15.1
michi-covalent
added a commit
that referenced
this pull request
May 7, 2024
Similar to #30496, make GitHub Actions runners for the CI image workflow configurable to make it easier to select more powerful runners as needed. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
May 7, 2024
Similar to #30496, use GH_RUNNER_EXTRA_POWER for the CI image workflow. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 7, 2024
Similar to #30496, use GH_RUNNER_EXTRA_POWER for the CI image workflow. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b20038e ("gha: explicilty specify beefier runner type for clustermesh workflows") explicitly configured beefier runners for clustermesh workflows, as they require more power to host two multi-node kind clusters. However, this change turned out to have unexpected billing consequences, even though GitHub recently upgraded [1] the default runners for OSS projects to 4 vCPU and 16GiB of RAM (the same specs of the runner which had been configured). Hence, let's revert this change, and instead make the runner type configurable through an environment variable. This will also make it easier to change the runner type in the future, if needed.
[1]: https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/
Fixes: b20038e ("gha: explicilty specify beefier runner type for clustermesh workflows")
Suggested-by: André Martins andre@cilium.io