Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add failed to list CRD to ignored warning logs #30778

Merged
merged 1 commit into from Feb 19, 2024

Conversation

learnitall
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This commit adds the 'failed to list CRDs' log - "the server could not find the requested resource" - to the list of accepted warning logs. This message is already in the list of ignored error logs, however this message can also appear as a warning log from klog.

Fixes: #30776
Related: #26591

Prevent E2E tests from failing on a known-ok warning log of temporary CRD failure

This commit adds the 'failed to list CRDs' log - "the server could not
find the requested resource" - to the list of accepted warning logs.
This message is already in the list of ignored error logs, however this
message can also appear as a warning log from klog.

Fixes: cilium#30776
Related: cilium#26591

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@learnitall learnitall added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Feb 15, 2024
@learnitall learnitall marked this pull request as ready for review February 15, 2024 20:41
@learnitall learnitall requested a review from a team as a code owner February 15, 2024 20:41
@aanm
Copy link
Member

aanm commented Feb 19, 2024

/test

@aanm aanm enabled auto-merge February 19, 2024 08:47
@aanm aanm added this pull request to the merge queue Feb 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 19, 2024
Merged via the queue into cilium:main with commit dceb890 Feb 19, 2024
60 checks passed
@tommyp1ckles tommyp1ckles added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Mar 5, 2024
@tommyp1ckles
Copy link
Contributor

Adding backport label as this issue has been cropping up in the v1.15 branch as well.

@pippolo84 pippolo84 mentioned this pull request Mar 5, 2024
13 tasks
@pippolo84 pippolo84 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 5, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: E2E Test 1.26: Failed to watch *v2.CiliumNode
5 participants