container/bitlpm: Add Lookup Boolean Return Value #31037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanjsweet
added
the
release-note/misc
Lookup currently returns the default value of the bitlpm.Trie when it fails to find a match. There are cases where comparing the default value to the return value is logically expensive (i.e. code needs to be written to do the comparison). Lookup can easily return a boolean value to indicate whether it failed. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
nathanjsweet
force-pushed
the
pr/nathanjsweet/update-bitlpm-lookup-to-return-success-boolean
branch
from
139f71e
to
8a8ce3d
Compare
squeed
approved these changes
Mar 4, 2024
|
/test |
nathanjsweet
added
needs-backport/1.14
nathanjsweet
deleted the
pr/nathanjsweet/update-bitlpm-lookup-to-return-success-boolean
branch
maintainer-s-little-helper
bot
added
the
ready-to-merge
pippolo84
added
backport-pending/1.15
pippolo84
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.2
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.8
github-actions
bot
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup currently returns the default value of
the bitlpm.Trie when it fails to find a match.
There are cases where comparing the
default value to the return value is logically expensive
(i.e. code needs to be written to do the comparison).
Lookup can easily return a boolean value to indicate
whether Lookup failed, making it easier for library
users to determine if Lookup failed.