Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator bgpv2 Test_NodeLabels is flaky #31054

Closed
bimmlerd opened this issue Feb 29, 2024 · 0 comments · Fixed by #31381
Closed

Operator bgpv2 Test_NodeLabels is flaky #31054

bimmlerd opened this issue Feb 29, 2024 · 0 comments · Fixed by #31381
Assignees
Labels
ci/flake This is a known failure that occurs in the tree. Please investigate me!

Comments

@bimmlerd
Copy link
Member

bimmlerd commented Feb 29, 2024

To repro locally:

  1. Install stress via go install golang.org/x/tools/cmd/stress@latest
  2. go test -c -race ./operator/pkg/bgpv2 && stress ./bgpv2.test -test.run=Test_NodeLabels

It's possible that other bgpv2 tests are also flaky, but this one gives the strongest signal: For me, this results in 1m0s: 152 runs so far, 24 failures (15.79%)

The cause is likely to be the usage of real informers against the fake K8s clientset. See https://github.com/kubernetes/client-go/blob/04ef61f72b7bc5ae6efef4e4dc0001746637fdb3/examples/fake-client/main_test.go#L74-L81 for an inspiration on how to fix this.

@bimmlerd bimmlerd added the ci/flake This is a known failure that occurs in the tree. Please investigate me! label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/flake This is a known failure that occurs in the tree. Please investigate me!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants