[v1.15] metrics: prepare to increase cardinality of BPF metrics key #31558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit b41b78d ] This commit is split off from subsequent commits to backport to 1.15. In a follow-up commit, the reserved space in metricsmap.Key will be used for storing line and file info. Since older versions of Cilium don't decode these fields yet, this either causes duplicate metrics to be displayed, or causes the last metricsmap entry with a given reason/direction combination to overwrite the counters of other entries, resulting in wrong metrics. metricsmapCollector.Collect() was believed to handle this correctly, but the code turned out to be wrong. The updated implementation sums up all values that resolve to the same label set. Various cleanups were made to remove type conversions and improve legibility. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
added
kind/backports
ti-mo
changed the title
|
/test-backport-1.15 |
squeed
approved these changes
Mar 25, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: