Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document No node ID found drops in case of remote node deletion #31635

Merged

Conversation

pchaigno
Copy link
Member

While testing cluster scale downs, we noticed that under constant traffic load, we sometimes had drops of type No node ID found. We confirmed that these are expected when the remote node was just deleted, the delete event received by the local agent, but a local pod is still sending traffic to pods on that node. In that case, the node is removed from the node ID map, but information on pods hosted by that node may still be present.

This pull request documents it with the other expected reasons for No node ID found drops.

While testing cluster scale downs, we noticed that under constant
traffic load, we sometimes had drops of type "No node ID found". We
confirmed that these are expected when the remote node was just deleted,
the delete event received by the local agent, but a local pod is still
sending traffic to pods on that node. In that case, the node is removed
from the node ID map, but information on pods hosted by that node may
still be present.

This commit documents it with the other expected reasons for "No node
ID found" drops.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch feature/ipsec Relates to Cilium's IPsec feature needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 26, 2024
@pchaigno pchaigno requested review from a team as code owners March 26, 2024 22:55
@pchaigno pchaigno requested a review from lambdanis March 26, 2024 22:55
@pchaigno
Copy link
Member Author

/test

@jschwinger233
Copy link
Member

Do we want to cover scale up and down in ci-ipsec-e2e?

@pchaigno pchaigno added this pull request to the merge queue Mar 27, 2024
@pchaigno
Copy link
Member Author

Do we want to cover scale up and down in ci-ipsec-e2e?

It would probably be good to cover it in CI, but maybe not for every PR. That workflow is already the longest.

Merged via the queue into cilium:main with commit e2e97f3 Mar 27, 2024
60 checks passed
@pchaigno pchaigno deleted the document-nonodeid-drops-node-deletion branch March 27, 2024 07:52
@joamaki joamaki mentioned this pull request Apr 2, 2024
8 tasks
@joamaki joamaki added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
10 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
13 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 2, 2024
@github-actions github-actions bot removed the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Apr 4, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants