New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document No node ID found
drops in case of remote node deletion
#31635
Merged
pchaigno
merged 1 commit into
cilium:main
from
pchaigno:document-nonodeid-drops-node-deletion
Mar 27, 2024
Merged
docs: Document No node ID found
drops in case of remote node deletion
#31635
pchaigno
merged 1 commit into
cilium:main
from
pchaigno:document-nonodeid-drops-node-deletion
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing cluster scale downs, we noticed that under constant traffic load, we sometimes had drops of type "No node ID found". We confirmed that these are expected when the remote node was just deleted, the delete event received by the local agent, but a local pod is still sending traffic to pods on that node. In that case, the node is removed from the node ID map, but information on pods hosted by that node may still be present. This commit documents it with the other expected reasons for "No node ID found" drops. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
added
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
area/encryption
Impacts encryption support such as IPSec, WireGuard, or kTLS.
release-note/misc
This PR makes changes that have no direct user impact.
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
feature/ipsec
Relates to Cilium's IPsec feature
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Mar 26, 2024
/test |
jschwinger233
approved these changes
Mar 27, 2024
Do we want to cover scale up and down in ci-ipsec-e2e? |
It would probably be good to cover it in CI, but maybe not for every PR. That workflow is already the longest. |
joamaki
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Apr 2, 2024
joamaki
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Apr 2, 2024
joamaki
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Apr 2, 2024
github-actions
bot
removed
the
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
label
Apr 4, 2024
github-actions
bot
added
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Apr 4, 2024
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
area/encryption
Impacts encryption support such as IPSec, WireGuard, or kTLS.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
feature/ipsec
Relates to Cilium's IPsec feature
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing cluster scale downs, we noticed that under constant traffic load, we sometimes had drops of type
No node ID found
. We confirmed that these are expected when the remote node was just deleted, the delete event received by the local agent, but a local pod is still sending traffic to pods on that node. In that case, the node is removed from the node ID map, but information on pods hosted by that node may still be present.This pull request documents it with the other expected reasons for
No node ID found
drops.