Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --cluster-name filter flag #1262

Closed
chancez opened this issue Oct 17, 2023 · 1 comment
Closed

Add --cluster-name filter flag #1262

chancez opened this issue Oct 17, 2023 · 1 comment
Assignees
@chancez
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. kind/enhancement This would improve or streamline existing functionality.
Milestone
Hubble CLI 1.0

Comments

@chancez
Copy link
Contributor

chancez commented Oct 17, 2023 •
edited

Currently filtering by cluster requires using --node-name <cluster-name>/ which isn't very intuitive and is a side-effect of how cluster names are stored in flows.

I propose we add a shortcut --cluster-name filter flag which internally gets translated to the equivalent node name filter.
@chancez chancez added kind/enhancement This would improve or streamline existing functionality. ⌨️ area/cli Impacts the command line interface of any command in the repository. labels Oct 17, 2023
@chancez chancez added this to the 1.0 milestone Oct 17, 2023
@chancez chancez self-assigned this Nov 21, 2023
@chancez
Copy link
Contributor Author

chancez commented Dec 13, 2023

Implemented in #1309

@chancez chancez closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chancez chancez

Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Milestone
Hubble CLI 1.0
Development

No branches or pull requests
1 participant
@chancez