Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observe all #253

Closed
glibsm opened this issue Apr 30, 2020 · 2 comments · Fixed by #411
Closed

Add observe all #253

glibsm opened this issue Apr 30, 2020 · 2 comments · Fixed by #411
Assignees
@rolinh
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. kind/enhancement This would improve or streamline existing functionality.

Comments

@glibsm
Copy link
Member

glibsm commented Apr 30, 2020

hubble observe --all is more friendly to get the whole buffer rather than something like hubble observe --since 100h
@rolinh rolinh mentioned this issue May 4, 2020
Closed
@glibsm
Copy link
Member Author

glibsm commented May 5, 2020

Should be tackled after cilium/cilium#11323 lands

@glibsm glibsm added the dont-merge/blocked PR/issue blocked by an external factor (be that PR, issue, or else) label May 5, 2020
@gandro gandro removed the dont-merge/blocked PR/issue blocked by an external factor (be that PR, issue, or else) label May 6, 2020
@rolinh rolinh added ⌨️ area/cli Impacts the command line interface of any command in the repository. kind/enhancement This would improve or streamline existing functionality. labels May 20, 2020
@rolinh rolinh mentioned this issue Jun 2, 2020
Merged
@gandro
Copy link
Member

gandro commented Jun 2, 2020

We probably also want to use it in Cilium CI, e.g. here: https://github.com/cilium/cilium/blob/e29e5ae34e01f266ec6b22c1454194131220440b/test/helpers/cons.go#L307

@rolinh rolinh self-assigned this Oct 27, 2020
This was referenced Oct 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolinh rolinh

Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/observe: add all flags cilium/hubble
3 participants
@gandro @glibsm @rolinh